Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused

From: Thierry Reding
Date: Tue May 29 2018 - 10:38:42 EST


On Mon, May 28, 2018 at 04:32:43PM +0200, Boris Brezillon wrote:
> +Thierry
>
> Hi Arnd,
>
> On Fri, 25 May 2018 17:50:15 +0200
> Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> > These two functions are unused in some configurations, and using __maybe_unused
> > is the easiest way to shut up the harmless warnings:
> >
> > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined but not used [-Werror=unused-function]
> > static int cdns_dsi_suspend(struct device *dev)
> > ^~~~~~~~~~~~~~~~
> > drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' defined but not used [-Werror=unused-function]
> > static int cdns_dsi_resume(struct device *dev)
> >
> > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Hm, I thought such a patch had already been applied by Thierry [1].
>
> [1]https://www.spinics.net/lists/dri-devel/msg174363.html

Yeah, that's in drm-misc-next, but didn't seem to have made it into
linux-next until today.

Thierry

Attachment: signature.asc
Description: PGP signature