Re: [PATCH net-next] net: qcom/emac: fix unused variable

From: Timur Tabi
Date: Wed May 30 2018 - 08:10:50 EST


On 5/29/18 5:43 AM, YueHaibing wrote:
When CONFIG_ACPI isn't set, variable qdf2400_ops/qdf2432_ops isn't used.
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:284:25: warning: âqdf2400_opsâ defined but not used [-Wunused-variable]
static struct sgmii_ops qdf2400_ops = {
^~~~~~~~~~~
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:276:25: warning: âqdf2432_opsâ defined but not used [-Wunused-variable]
static struct sgmii_ops qdf2432_ops = {
^~~~~~~~~~~

Move the declaration and functions inside the CONFIG_ACPI ifdef
to fix the warning.
Signed-off-by: YueHaibing<yuehaibing@xxxxxxxxxx>

I already fixed this with:

https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=d377df784178bf5b0a39e75dc8b1ee86e1abb3f6

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.