Re: [PATCH v2 00/25] staging: lustre: libcfs: SMP rework

From: Greg Kroah-Hartman
Date: Fri Jun 01 2018 - 04:29:07 EST

On Tue, May 29, 2018 at 10:21:40AM -0400, James Simmons wrote:
> From: James Simmons <uja.ornl@xxxxxxxxx>
> Recently lustre support has been expanded to extreme machines with as
> many as a 1000+ cores. On the other end lustre also has been ported
> to platforms like ARM and KNL which have uniquie NUMA and core setup.
> For example some devices exist that have NUMA nodes with no cores.
> With these new platforms the limitations of the Lustre's SMP code
> came to light so a lot of work was needed. This resulted in this
> patch set which has been tested on these platforms.

That's great work, but why is this happening instead of effort to get
this out of the staging tree? I see a mix of "clean this up" combined
with "add this new feature" happening here, and I am getting tired of

I keep saying, "no new features until this gets out of staging", so why
isn't anyone working directly on getting this out of staging? I can
only assume the reason why is because I keep being "nice" and accepting
random new feature additions :(

So, no more, I'm really really really tired of dealing with this
filesystem for all of these years. There is still loads to do to get
this cleaned up and moved out (as my simple debugfs cleanup patch series
showed). So please do it.

Again, I am not going to take any more new feature additions or anything
that does not obviously look like an attempt to get this code cleaned up
into mergable shape. Adding things like "now works on systems with
thousands of CPUs as well as an RPi" is not such work, unless you can
directly show me an end result of cleaner, smaller, and more easily
reviewable code.

This patch series is now dropped, if you think it meets the above
criteria, please feel free to resend it to be judged in this manner.


greg k-h