Re: [PATCH v3 1/6] mtd: rawnand: add Reed-Solomon error correction algorithm

From: Boris Brezillon
Date: Fri Jun 01 2018 - 05:25:22 EST


On Fri, 1 Jun 2018 09:26:00 +0200
Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote:

> On Fri, 1 Jun 2018 00:16:32 +0200
> Stefan Agner <stefan@xxxxxxxx> wrote:
>
> > Add Reed-Solomon (RS) to the enumeration of ECC algorithms.
> >
> > Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
>
> > ---
> > drivers/mtd/nand/raw/nand_base.c | 1 +
> > include/linux/mtd/rawnand.h | 1 +

Hm, you forgot to update Documentation/devicetree/bindings/mtd/nand.txt.

> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> > index f28c3a555861..9eb5678dd6d0 100644
> > --- a/drivers/mtd/nand/raw/nand_base.c
> > +++ b/drivers/mtd/nand/raw/nand_base.c
> > @@ -5744,6 +5744,7 @@ static int of_get_nand_ecc_mode(struct device_node *np)
> > static const char * const nand_ecc_algos[] = {
> > [NAND_ECC_HAMMING] = "hamming",
> > [NAND_ECC_BCH] = "bch",
> > + [NAND_ECC_RS] = "rs",
> > };
> >
> > static int of_get_nand_ecc_algo(struct device_node *np)
> > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> > index 5dad59b31244..6a82da8c44ce 100644
> > --- a/include/linux/mtd/rawnand.h
> > +++ b/include/linux/mtd/rawnand.h
> > @@ -114,6 +114,7 @@ enum nand_ecc_algo {
> > NAND_ECC_UNKNOWN,
> > NAND_ECC_HAMMING,
> > NAND_ECC_BCH,
> > + NAND_ECC_RS,
> > };
> >
> > /*
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/