Re: [PATCH] staging: pi433: add rw semaphore fixing concurrency issues

[Hugo Lefeuvre]

Hi Valdis,

> > @@ -805,9 +809,11 @@ pi433_read(struct file *filp, char __user *buf, size_t size, loff_t *f_pos)
> >  	if (bytes_received > 0) {
> >  		retval = copy_to_user(buf, device->rx_buffer, bytes_received);
> >  		if (retval)
> > +			up_read(&instance->instance_sem);
> >  			return -EFAULT;
> >  	}
> >
> > +	up_read(&instance->instance_sem);
> >  	return bytes_received;
> >  }
> 
> This doesn't do what you think.

Oh right, no curly braces, didn't notice it. Thanks !

Otherwise, do you think the usage of rw semaphore is appropriate in this
case ?

Regards,
 Hugo

-- 
             Hugo Lefeuvre (hle)    |    www.owl.eu.com
4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA