Re: [PATCH] perf tools: Fix hist_entry__tui_annotate declaration for !HAVE_SLANG_SUPPORT

From: Arnaldo Carvalho de Melo
Date: Fri Jun 01 2018 - 12:04:22 EST


Em Fri, Jun 01, 2018 at 05:21:55PM +0200, Jiri Olsa escreveu:
> On Fri, Jun 01, 2018 at 10:19:57AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Jun 01, 2018 at 11:56:48AM +0200, Jiri Olsa escreveu:
> > > Adding the missing argument to hist_entry__tui_annotate function.

> > Thanks, I think I have this fixed locally.

> > > +++ b/tools/perf/util/hist.h
> > > @@ -446,7 +446,8 @@ static inline int map_symbol__tui_annotate(struct map_symbol *ms __maybe_unused,
> > >
> > > static inline int hist_entry__tui_annotate(struct hist_entry *he __maybe_unused,
> > > struct perf_evsel *evsel __maybe_unused,
> > > - struct hist_browser_timer *hbt __maybe_unused)
> > > + struct hist_browser_timer *hbt __maybe_unused,
> > > + struct annotation_options *annotation_opts)
>
> good, because I sent you wrong one.. without __maybe_unused ;-) sry

Erm, I hadn't, so I just fixed this and force pushed perf/core

https://git.kernel.org/acme/c/2b90f5c0c0a6

- Arnaldo