Re: [PATCH 01/39] vfs: dedpue: return loff_t
From: Christoph Hellwig
Date: Mon Jun 04 2018 - 04:43:42 EST
On Tue, May 29, 2018 at 04:43:01PM +0200, Miklos Szeredi wrote:
> f_op->dedupe_file_range() gets a u64 length to dedup and returns an ssize_t
> actual length deduped. This breaks badly on 32bit archs since the returned
> length will be truncated and possibly overflow into the sign bit (xfs and
> ocfs2 are affected, btrfs limits actual length to 16MiB).
Can we just make it return 0 vs errno? The only time we return
a different length than the one passed in is due to the btrfs cap.
Given that this API started out on btrfs we should just do the cap
everywhere to not confuse userspace.