Re: [PATCH] fsl/qe: ucc: copy and paste bug in ucc_get_tdm_sync_shift()
From: Dan Carpenter
Date: Mon Jun 04 2018 - 09:40:51 EST
On Mon, Jun 04, 2018 at 10:25:14PM +0900, Julia Lawall wrote:
> On Mon, 4 Jun 2018, Dan Carpenter wrote:
> > There is a copy and paste bug so we accidentally use the RX_ shift when
> > we're in TX_ mode.
> > Fixes: bb8b2062aff3 ("fsl/qe: setup clock source for TDM mode")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > Static analysis work. Not tested. This affects the success path, so
> > we should probably test it.
> Maybe this is another one? I don't have time to look into it at the
> /* For strict priority entries defines the number of consecutive
> * slots for the highest priority.
> REG_WR(bp, (port) ? NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS :
> NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS, 0x100);
> /* Mapping between the CREDIT_WEIGHT registers and actual client
> * numbers
> I find some others that choose between constants, such as ... ? 0 : 0.
I feel like it should warn about all of those because people shouldn't
be submitting unfinished written code to the kernel. Coccinelle is a
lot better for this than Smatch is because it's pre-processor stuff.