Re: [PATCH] ACPI LID: increment wakeup count only when notified.
From: Rafael J. Wysocki
Date: Wed Jun 06 2018 - 19:21:30 EST
On Thu, Jun 7, 2018 at 1:11 AM, Benson Leung <bleung@xxxxxxxxxx> wrote:
> Hi Rafael,
> On Wed, Jun 06, 2018 at 09:00:43AM +0200, Rafael J. Wysocki wrote:
>> > @@ -417,6 +414,7 @@ static void acpi_button_notify(struct acpi_device *device, u32 event)
>> > /* fall through */
>> > case ACPI_BUTTON_NOTIFY_STATUS:
>> > input = button->input;
>> > + acpi_pm_wakeup_event(&device->dev);
>> Not really.
>> There already is an acpi_pm_wakeup_event() call in the else branch below.
> Ravi removes that other call below.
OK, I missed that, not sure why, sorry.
> The intent for this is to call
> acpi_pm_wakeup_event() regardless if the button->type is ACPI_BUTTON_TYPE_LID,
> in case that event is ACPI_BUTTON_NOTIFY_STATUS.
Well, the patch really drops the acpi_pm_wakeup_event() call from
acpi_lid_notify_state() and so it has to ensure that this function
will be called here for ACPI_BUTTON_NOTIFY_STATUS regardless of the
That's fine, but still the changelog doesn't make it clear why the
acpi_pm_wakeup_event() call in acpi_lid_notify_state() is not
necessary in general.