Re: [PATCH 08/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver

From: Finn Thain
Date: Thu Jun 07 2018 - 01:28:57 EST


On Wed, 6 Jun 2018, Geert Uytterhoeven wrote:

> So 4.17 mac_defconfig won't work on PMU_68K_V1 machines? Perhaps that
> should be fixed first.
>

AFAICT there's nothing to fix.

$ grep PMU arch/m68k/configs/mac_defconfig
CONFIG_ADB_PMU68K=y

This works fine for PMU_68K_V2 machines. But if you try to boot a
PMU_68K_V1 machine, you will have trouble starting the kernel. Sometimes
you can boot by fiddling with ADB devices, but not always. This is not a
new problem. The via-pmu68k driver has never worked on PMU_68K_V1
machines.

So as far as PMU_68K_V1 is concerned, there's no need to bisect any of the
changes under review. To answer your question, "Shouldn't that be a
separate patch?", all I can say is "not to my knowledge". But I'm probably
missing something.

--