Re: [PATCH v5 01/14] mfd: da9063: Replace regmap_add_irq_chip with devm counterpart
From: Lee Jones
Date: Fri Jun 08 2018 - 02:37:26 EST
On Thu, 07 Jun 2018, Marek Vasut wrote:
> On 06/07/2018 02:41 PM, Lee Jones wrote:
> > On Thu, 07 Jun 2018, Marek Vasut wrote:
> >> On 06/06/2018 11:59 AM, Marek Vasut wrote:
> >>> Use devm_regmap_add_irq_chip() instead of plain regmap_add_irq_chip(),
> >>> which removes the need for da9063_irq_exit() altogether and also
> >>> fixes a bug in da9063_device_init() where the da9063_irq_exit() was
> >>> not called in a failpath.
> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
> >>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >>> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> >>> Cc: Mark Brown <broonie@xxxxxxxxxx>
> >>> Cc: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> >>> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> >>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> >> So it's just this one patch that's missing AB/RB and the series should
> >> be good?
> > Looks fine. Although we'll let it sit for a while in case anyone else
> > has any thoughts.
> Fine by me.
> > The merge window is currently open, so there is no rush to apply.
> This is still 4.18 material ? Hum, OK.
You mean this could be added to v4.18? If so, not a chance. I
normally cut off accepting trivial patches at around -rc6(ish). Large
sets like this require a longer soak in -next for all of the build
bots and testers to have their wicked way with them and for potential
merge conflicts to show.
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog