Re: [PATCH v2 11/11] misc: throttler: Add Chrome OS EC throttler
From: Matthias Kaehlcke
Date: Fri Jun 08 2018 - 11:56:52 EST
On Fri, Jun 08, 2018 at 04:09:18PM +0200, Enric Balletbo i Serra wrote:
> On 07/06/18 20:12, Matthias Kaehlcke wrote:
> > The driver subscribes to throttling events from the Chrome OS
> > embedded controller and enables/disables system throttling based
> > on these events.
> > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> > ---
> > Changes in v2:
> > - added SPDX line instead of license boiler-plate
> > - use macro to avoid splitting line
> > - changed variable name for throttler from 'cte' to 'ce_thr'
> > - formatting fixes
> > - Kconfig: removed odd dashes around 'help'
> > - added 'Reviewed-by' tag
> > Note: I finally decided to keep 'Chrome OS' instead of changing it
> > to 'ChromeOS'. Both are currently used in the kernel, the latter is
> > currently more prevalent, however the official name is 'Chrome OS',
> > so there is no good reason to keep introducing the 'alternative' name.
> I am pretty sure that somebody from Google told me the contrary, so
> Anyway, you will probably know better than me :)
The different names in the kernel code indicate that even folks at
Google disagree on this ;-) The name might have evolved over time.
chrome://chrome on a Chromebook names it 'Chrome OS', as do official
pages like https://www.google.com/chromebook/ and
https://www.chromium.org/chromium-os so I think it is better to use
> > +MODULE_LICENSE("GPL");
> Something that I learnt recently. To match the SPDX-license tag you should set
> this to "GPL v2" 
> * "GPL" [GNU Public License v2 or later]
> * "GPL v2" [GNU Public License v2]
>  https://elixir.bootlin.com/linux/v4.17/source/include/linux/module.h#L172
Will update in the next revision