Re: [PATCH 0/2] fs/lock: show locks info owned by dead/invisible processes
From: Cyrill Gorcunov
Date: Fri Jun 08 2018 - 12:02:52 EST
On Fri, Jun 08, 2018 at 05:27:10PM +0300, Konstantin Khorenko wrote:
> The behavior has been changed after 9d5b86ac13c5 ("fs/locks: Remove fl_nspid
> and use fs-specific l_pid for remote locks")
> and now /proc/$PID/fdinfo/$FD does not show the info about the lock
> * if the flock owner process is dead and its pid has been already freed
> * if the lock owner is not visible in current pidns.
> CRIU uses this interface to store locks info during dump and thus can break
> on v4.13 and newer.
Indeed, it should cause problems with procfs parsing. We should add a test
for such scenarions, and since we're running tests by linux-next all the time
we would have this issue catched already.
The series looks ok to me, but I'm not flock expert so better wait for more
> So let's show info about locks anyway in described cases (like it was before
> 9d5b86ac13c5), but show pid number saved in file_lock struct if we are in
> init_pid_ns (patch 1) or just zero otherwise (patch 2) like we do with SID.