Re: [PATCH] mfd: cros_ec: remove unused __remove function

From: Benson Leung
Date: Fri Jun 08 2018 - 14:20:11 EST

On Fri, Jun 08, 2018 at 04:48:06PM +0200, Arnd Bergmann wrote:
> This function is no longer called, so we get a harmless
> warning until it is removed as well:
> drivers/mfd/cros_ec_dev.c:265:13: error: '__remove' defined but not used [-Werror=unused-function]
> Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")

Gwendal, in PATCH v2 of
you mentioned that you readded the __remove to avoid a warning when built
as a module. Can you explain what's going on?


Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
Chromium OS Project

Attachment: signature.asc
Description: PGP signature