Re: [PATCH v2 05/11] PM / devfreg: Add support for policy notifiers

From: kbuild test robot
Date: Fri Jun 08 2018 - 21:17:33 EST


Hi Matthias,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/Add-throttler-driver-for-non-thermal-throttling/20180609-061437
config: i386-randconfig-a0-201822 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

In file included from include/trace/events/thermal.h:8:0,
from drivers/thermal/thermal_helpers.c:24:
>> include/linux/devfreq.h:447:3: warning: 'struct defreq_policy' declared inside parameter list
unsigned int min, unsigned int max)
^
>> include/linux/devfreq.h:447:3: warning: its scope is only this definition or declaration, which is probably not what you want
>> include/linux/devfreq.h:452:41: warning: 'struct cpufreq_policy' declared inside parameter list
devfreq_verify_within_dev_limits(struct cpufreq_policy *policy)
^

vim +447 include/linux/devfreq.h

445
446 static inline void devfreq_verify_within_limits(struct defreq_policy *policy,
> 447 unsigned int min, unsigned int max)
448 {
449 }
450
451 static inline void
> 452 devfreq_verify_within_dev_limits(struct cpufreq_policy *policy)
453 {
454 }
455

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip