Re: [PATCH 2/2] IB/mad: Use IDR for agent IDs
From: Leon Romanovsky
Date: Sun Jun 10 2018 - 08:30:56 EST
On Sun, Jun 10, 2018 at 03:43:05AM -0700, Matthew Wilcox wrote:
> On Sun, Jun 10, 2018 at 09:30:28AM +0300, Leon Romanovsky wrote:
> > 1. IBTA spec doesn't talk at all about the size of TransactionID, more
> > on that in section "22.214.171.124 TRANSACTION ID USAGE", the specification
> > says: "The contents of the TransactionID (TID) field are implementation-
> > dependent. So let's don't call it mlx4 bug.
> I was loosely paraphrasing the original bug report; suggested rewording
> of the comments gratefully accepted.
Just replace "mlx4 bug" with something like "to comply with mlx4
> > 2. The current implementation means that in mlx5-only network we will
> > still have upto (1 << 24) TIDs. I don't know if it is really important,
> > but worth to mention.
> Actually, the TIDs will be up to 2^56. We're limited to 2^24 clients,
> each of which can send up to 2^32 messages.
It sounds like more than enough.
Description: PGP signature