Re: [PATCH 0/3] Legacy clock drivers: Normalize clk API
From: Arnd Bergmann
Date: Mon Jun 11 2018 - 05:03:00 EST
On Mon, Jun 11, 2018 at 10:44 AM, Geert Uytterhoeven
> Hi all,
> When seeing commit bde4975310eb1982 ("net: stmmac: fix build failure due
> to missing COMMON_CLK dependency"), I wondered why this dependency is
> needed, as all implementations of the clock API should implement all
> required functionality, or provide dummies.
> It turns out there were still two implementations that lacked the
> clk_set_rate() function: Coldfire and AR7.
> This series contains three patches:
> - The first two patches add dummies for clk_set_rate(),
> clk_set_rate(), clk_set_parent(), and clk_get_parent() to the
> Coldfire and AR7, like Arnd has done for other legacy clock
> implementations a while ago.
> - The second patch removes the COMMON_CLK dependency from the stmmac
> network drivers again, as it is no longer needed.
> Obviously this patch has a hard dependency on the first two patches.
Yes, good idea.
Acked-by: Arnd Bergmann <arnd@xxxxxxx>
One question: what happens on machines that don't support any CLK
that don't have any of COMMON_CLK/HAVE_CLK/CLKDEV_LOOKUP?
I guess those are already hopelessly broken for many drivers, right?