Re: [PATCH v6 4/5] clocksource: add driver for i.MX EPIT timer
From: Vladimir Zapolskiy
Date: Mon Jun 11 2018 - 10:40:11 EST
On 06/07/2018 05:05 PM, ClÃment PÃron wrote:
> From: Colin Didier <colin.didier@xxxxxxxxxxxx>
> Add driver for NXP's EPIT timer used in i.MX SoC.
> Signed-off-by: Colin Didier <colin.didier@xxxxxxxxxxxx>
> Signed-off-by: ClÃment Peron <clement.peron@xxxxxxxxxxxx>
Reviewed-by: Vladimir Zapolskiy <vz@xxxxxxxxx>
Tested-by: Vladimir Zapolskiy <vz@xxxxxxxxx>
I tested the driver on i.MX31 only, and I didn't find any problems.
Please fix the indentation issue found by Stefan in v7.
Regarding utilization of timer-of.c it can be postponed IMHO,
but it's up to clocksource maintainers and you to decide, and if
you do such an update for v7, then please don't add my tags,
I'll review and test it again.
With best wishes,