Re: [PATCH] net: cxgb3: add error handling for some functions

From: David Miller
Date: Mon Jun 11 2018 - 17:23:27 EST

From: Zhouyang Jia <jiazhouyang09@xxxxxxxxx>
Date: Mon, 11 Jun 2018 16:42:26 +0800

> When sysfs_create_group or alloc_skb fails, the lack of error-handling
> code may cause unexpected results.
> This patch adds error-handling code after the functions.
> Signed-off-by: Zhouyang Jia <jiazhouyang09@xxxxxxxxx>

The ->nofail_skb handling is perfectly fine.

It is a backup SKB, meant to handle alloc_skb() failures for the
primary 'skb' allocation the _next_ time this function is called.

Even if the ->nofail_skb allocation fails, the primary operation
done by init_tp_parity() has succeeeded and we should return

All of the code in this function is perfectly prepared to handle
the case where ->nofail_skb is NULL.