Re: [PATCH] serial: 8250_dw: 8250_dw need to depend on COMMON_CLK
From: Geert Uytterhoeven
Date: Tue Jun 12 2018 - 04:32:09 EST
On Mon, Jun 11, 2018 at 11:03 PM Andy Shevchenko
> On Wed, Jun 6, 2018 at 10:27 PM Corentin Labbe <clabbe@xxxxxxxxxxxx> wrote:
> > This patch fix the following build error on M68K:
Not plain m68k, but coldfire only (and MIPS AR7, I guess).
> > drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios':
> > 8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate'
> > 8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate'
> > So 8250_dw need to depend on COMMON_CLK.
> Makes sense.
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Please see "[PATCH 0/3] Legacy clock drivers: Normalize clk API"
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds