Re: [PATCH] drivers/of: Add devm_of_iomap()
From: Andy Shevchenko
Date: Tue Jun 12 2018 - 13:02:35 EST
On Tue, Jun 12, 2018 at 1:28 PM, Benjamin Herrenschmidt
> On Tue, 2018-06-12 at 11:35 +0300, Andy Shevchenko wrote:
>> On Tue, Jun 12, 2018 at 3:01 AM, Benjamin Herrenschmidt
>> <benh@xxxxxxxxxxxxxxxxxxx> wrote:
>> > There are still quite a few cases where a device might want to get to a
>> > different node of the device-tree, obtain the resources and map them.
>> > Drivers doing that currently open code the whole thing, which is error
>> > proe.
>> > We have of_iomap() and of_io_request_and_map() but they both have shortcomings,
>> > such as not returning the size of the resource found (which can be necessary)
>> > and not being "managed".
>> > This adds a devm_of_iomap() that provides all of these and should probably
>> > replace uses of the above in most drivers.
>> It feels like a wrong approach.
>> Can OF graph help here? Would it be better approach?
> I don't quite understand what your objection is nor what "OF graph"
There is no objection per se, just a doubt that this is a right thing to do.
I might be wrong, of course.
OF graph nodes is a special API that allows you to access like you
said "different node of device-tree".
> This is a direct replacement for the open coded equivalent that a
> number of drivers do, almost always without using devm_* or forgetting
> to request the resources etc... Ie, a less bug-prone tool in the
> So there's a real use case here.
I believe you, though as I mentioned that simplification doesn't feel
right. Like jumping out of the frying pan into the fire.
> In fact a driver I'm going to submit soon uses it, which is why I wrote
> it in the first place, rather than adding yet another open-coded case.
Good, but check with graphs first. If it's not suitable would be nice
to know why.
> And to reply to the inevitable next reaction, NO this is not a case for
> creating yet another 237 layers of abstractions. Sometimes, a driver
> needs to directly access (no regmap overhead please) some regions
> represented by a specific DT node (it could be a child of the device
> for example representing a portion of its register space, or it could
> be a separate piece of HW that needs to be used by the device but
> doesn't fit in any abstract model and shouldn't).
With Best Regards,