Re: [PATCH v6 3/4] powerpc/lib: implement strlen() in assembly
From: Michael Ellerman
Date: Tue Jun 12 2018 - 23:58:31 EST
Christophe LEROY <christophe.leroy@xxxxxx> writes:
> Le 12/06/2018 Ã 16:53, Segher Boessenkool a ÃcritÂ:
>> On Tue, Jun 12, 2018 at 09:14:53AM +0000, Christophe Leroy wrote:
>>> Not tested on PPC64.
>> It won't be acceptable until that happens. It also is likely quite bad
>> performance on all 64-bit CPUs from the last fifteen years or so. Or you
>> did nothing to prove otherwise, at least.
> Will it be as bad as the generic implementation which does it byte per
> byte ?
> I don't have any 64 bits target, can someone test it using the test app
> I have added in selftests ?
I /can/ but I won't have time this week.
> Or should I just leave it as is for 64 bits and just do the
> implementation for 32 bits until someone wants to try and do it for PPC64 ?
That's probably best yeah.