Re: [PATCH v4 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ FW bindings

From: Sudeep Holla
Date: Thu Jun 14 2018 - 06:47:41 EST

On 13/06/18 19:13, Taniya Das wrote:
> Hello Sudeep,
> Thanks for review comments.
> On 6/13/2018 4:56 PM, Sudeep Holla wrote:


>> You are bit inconsistent on the wordings. Some places you refer this as
>> hardware engine. If so, please drop all references to firmware/FW. If
>> it's firmware then update accordingly.
> It is a hardware engine which has a firmware to take care of the
> managing the frequency request from OS. That is reason to refer it as a
> firmware.

Yes I did guess that initially, but I failed to understand when
different bindings were posted to deal with devfreq and cpufreq with the
same firmware. Ideally if it's the firmware you are talking to, place
all these under /firmware node and align all those with single binding.

Is there anything else that this firmware deals with ? If so all those
need to be put in one place.

>>> +Properties:
>>> +- compatible
>>> +ÂÂÂ Usage:ÂÂÂÂÂÂÂ required
>>> +ÂÂÂ Value type:ÂÂÂ <string>
>>> +ÂÂÂ Definition:ÂÂÂ must be "qcom,cpufreq-fw".
>>> +
>>> +* Property qcom,freq-domain
>>> +Devices supporting freq-domain must set their "qcom,freq-domain"
>>> property with
>>> +phandle to a freq_domain_table in their DT node.
>>> +
>>> +* Frequency Domain Table Node
>>> +
>>> +This describes the frequency domain belonging to a device.
>>> +This node can have following properties:
>>> +
>>> +- reg
>>> +ÂÂÂ Usage:ÂÂÂÂÂÂÂ required
>>> +ÂÂÂ Value type:ÂÂÂ <prop-encoded-array>
>>> +ÂÂÂ Definition:ÂÂÂ Addresses and sizes for the memory of the perf
>>> +ÂÂÂÂÂÂÂÂÂÂÂ , lut and enable bases.
>>> +ÂÂÂÂÂÂÂÂÂÂÂ perf - indicates the base address for the desired
>>> +ÂÂÂÂÂÂÂÂÂÂÂ performance state to be set.
>>> +ÂÂÂÂÂÂÂÂÂÂÂ lut - indicates the look up table base address for the
>>> +ÂÂÂÂÂÂÂÂÂÂÂ cpufreqÂÂÂ driver to read frequencies.
>>> +ÂÂÂÂÂÂÂÂÂÂÂ enable - indicates the enable register for firmware.
>> You still didn't answer my earlier question.
>> OS might touch one or 2 registers in lots of IP blocks. I am not sure
>> why those are any different from these. Are you trying to align with any
>> other bindings or specification. Are you trying to make this binding
>> generic here ? I understand if it was trying to generalize the firmware
>> interface, but you also state it's a hardware engine. So I fail to see
>> the need for such specificity here. Why not define the whole IP block
>> and the driver knows where to access these specific ones as they are
>> specific to this hardware block. In that way if you decide to add more
>> data, it's extensible easily without the need for patching DT.
> Sorry Sudeep I missed replying to your earlier query.
> The High level OS(HLOS) would require to access only these specific
> registers from this IP block and just mapping the whole block(huge
> region) is unnecessary from the OS point of View. As of now it is a
> generic binding for all using this IP block to manage frequency
> requests. The OS would only have to know the frequencies supported i.e
> to read the lookup table registers and put across the OS request using
> the performance state register.

I am not sure if you need to defining bindings to save OSPM IO mapping.
In-fact you may be adding more mapping unnecessarily. The mappings are
page aligned and spiting the registers and mapping them individually may
result in more mappings.

I just need to know the rational for such specific choice of registers.
I assume it's aligned to some other standard specifications like CPPC
though not identical.

>> Eg. Suppose you need some information on power curve for EAS energy
>> model, I really hate to update DT for that or even do a mix with DT just
>> because f/w is no longer modifiable.
> For now we are safe.

What do you mean by that ? It should be easily extensible is what I am
trying to say. You can add more info and alter the information in the
driver with compatibles if you keep the register info as minimum as
possible. For now, you have enable, set and lut registers. What if you
want to provide power numbers ?