Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex
From: Mark Brown
Date: Thu Jun 14 2018 - 09:48:21 EST
On Wed, Jun 13, 2018 at 09:00:19PM +0200, Robert Jarzmik wrote:
> Rob Herring <robh@xxxxxxxxxx> writes:
> > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote:
> >> +Required properties:
> >> + - compatible: "marvell,pxa2xx-ac97"
> > Don't use wildcards in compatible strings. Though this is so old...
> Yes, I could use pxa270-ac97.
If you're going to do that then probably best to put in a compatible
string for each SoC since they are actually meaningfully different, they
seemed to manage to break something with each new revision.
Description: PGP signature