[PATCH 4.16 19/43] usb: gadget: udc: renesas_usb3: fix double phy_put()

From: Greg Kroah-Hartman
Date: Thu Jun 14 2018 - 10:08:14 EST

4.16-stable review patch. If anyone has any objections, please let me know.


From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

commit 8223b2f89ca63e203dcb54148e30d94979f17b0b upstream.

This patch fixes an issue that this driver cause double phy_put()
calling. This driver must not call phy_put() in the remove because
the driver calls devm_phy_get() in the probe.

Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic phy")
Cc: <stable@xxxxxxxxxxxxxxx> # v4.15+
Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/usb/gadget/udc/renesas_usb3.c | 2 --
1 file changed, 2 deletions(-)

--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2408,8 +2408,6 @@ static int renesas_usb3_remove(struct pl
renesas_usb3_dma_free_prd(usb3, &pdev->dev);

- if (usb3->phy)
- phy_put(usb3->phy);

return 0;