Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h>
From: Sedat Dilek
Date: Fri Jun 15 2018 - 00:04:58 EST
On Thu, Jun 14, 2018 at 10:59 PM, Nick Desaulniers
> On Thu, Jun 14, 2018 at 1:48 PM H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>> On 06/13/18 14:05, Nick Desaulniers wrote:
>> > From: "H. Peter Anvin" <hpa@xxxxxxxxxxxxxxx>
>> > i386 and x86-64 uses different registers for arguments; make them
>> > available so we don't have to #ifdef in the actual code.
>> > Native size and specified size (q, l, w, b) versions are provided.
>> > Suggested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
>> > Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
>> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>> I still object to Suggested-by: here. Sedat did a correction, which is
>> a Reviewed-by:, but unless I'm completely out to sea, there was no
>> suggestion on Sedat's part of this; and I had certainly not seen it when
>> I wrote the code.
> I'm fine with changing it from a Suggested-by to a Reviewed-by. Can
> you do that when you apply the set, or should I send a v6?
this issue with Clang and Paravirt is such an ancient issue.
Back to the days in 2011 before LLVMlinux was born, the project was
Fact is the issue is today fixed.
Not sure about the credits Suggested-by/Reviewed-by in the
Linux-kernel development process.
I did not count the number of compiler runs here.
A Tested-by is OK for me.
Anyway, the beast is dead, this counts for me.
- Sedat -