Re: [PATCH] gpio: max732x: add error handling for i2c_new_dummy

From: Andy Shevchenko
Date: Fri Jun 15 2018 - 05:01:32 EST


On Thu, Jun 14, 2018 at 5:27 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Jun 12, 2018 at 5:28 AM, Zhouyang Jia <jiazhouyang09@xxxxxxxxx> wrote:
>
>> When i2c_new_dummy fails, the lack of error-handling code may
>> cause unexpected results.
>>
>> This patch adds error-handling code after calling i2c_new_dummy.
>>
>> Signed-off-by: Zhouyang Jia <jiazhouyang09@xxxxxxxxx>
>
> Patch applied for non-critical fixes.

It might potentially be a regression if the driver used to work when
dummy device creation failed.

>
> Yours,
> Linus Walleij



--
With Best Regards,
Andy Shevchenko