Re: [PATCH 0/8] Fix breakage caused by the NTB multi-port patchset
From: Serge Semin
Date: Fri Jun 15 2018 - 15:47:17 EST
On Fri, Jun 08, 2018 at 06:08:10PM -0600, Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:
Good day, Logan.
Thanks for the patchset you submitted. My hopefully useful comments are
under the corresponding patches.
> Here are all the fixes required to get ntb_test on switchtec working
> again after the multi-port test patches were merged.
> I'd appreciate it if future changes can be a) more careful about
> not breaking things, b) communicated more clearly so that better
> review can be done, and c) not merged until sufficient review actually
> is done.
> Note, I sent the first patch in this series earlier; please disregard
> the earlier one.
> Logan Gunthorpe (8):
> NTB: ntb_tool: reading the link file should not end in a NULL byte
> NTB: Setup the DMA mask globally for all drivers
> NTB: Fix the default port and peer numbers for legacy drivers
> NTB: ntb_pingpong: Choose doorbells based on port number
> NTB: perf: Don't require one more memory window than number of peers
> NTB: perf: Fix support for hardware that doesn't have port numbers
> NTB: perf: Fix race condition when run with ntb_test
> NTB: ntb_test: Fix bug when counting remote files
> drivers/ntb/hw/amd/ntb_hw_amd.c | 4 ----
> drivers/ntb/hw/idt/ntb_hw_idt.c | 6 ------
> drivers/ntb/hw/intel/ntb_hw_intel.c | 4 ----
> drivers/ntb/ntb.c | 22 ++++++++++++++--------
> drivers/ntb/test/ntb_perf.c | 22 +++++++++++++++++++---
> drivers/ntb/test/ntb_pingpong.c | 14 ++++++--------
> drivers/ntb/test/ntb_tool.c | 3 +--
> tools/testing/selftests/ntb/ntb_test.sh | 2 +-
> 8 files changed, 41 insertions(+), 36 deletions(-)
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to linux-ntb@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/20180609000819.13883-1-logang%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.