Re: [PATCH v3 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa
From: Matthias Kaehlcke
Date: Fri Jun 15 2018 - 17:25:53 EST
On Fri, Jun 15, 2018 at 02:06:21PM -0700, Brian Norris wrote:
> On Thu, Jun 14, 2018 at 12:47:01PM -0700, Matthias Kaehlcke wrote:
> > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding
> > the devfreq device") introduced the initialization of the user
> > limits min/max_freq from the lowest/highest available OPPs. Later
> > commit f1d981eaecf8 ("PM / devfreq: Use the available min/max
> > frequency") added scaling_min/max_freq, which actually represent
> > the frequencies of the lowest/highest available OPP. scaling_min/
> > max_freq are initialized with the values from min/max_freq, which
> > is totally correct in the context, but a bit awkward to read.
> > Swap the initialization and assign scaling_min/max_freq with the
> > OPP freqs and then the user limts min/max_freq with scaling_min/
> > max_freq.
> > Needless to say that this change is a NOP, intended to improve
> > readability.
> > ---
> BTW, putting the '---' here means that stuff below it usually gets
> dropped when applied (e.g., with git-am). So it'll drop your
> Signed-off-by and Reviewed-by. Not a huge problem if the maintainers
> look out for that.
It wasn't intended and is related with my current workflow: To keep
easily track of deltas in my tree and have the changelog ready when
sending the patches I currently keep the changelog in the commit
message and manually move it below '---' when doing 'git send-email'.
Seems I got it wrong in this case :(
> > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>