Re: [PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass

From: Nick Desaulniers
Date: Fri Jun 15 2018 - 18:58:47 EST


On Fri, Jun 15, 2018 at 3:56 PM Nick Desaulniers
<ndesaulniers@xxxxxxxxxx> wrote:
>
> Similar to commit 0bf8bf50eddc ("module: Remove
> const attribute from alias for MODULE_DEVICE_TABLE")
>
> Fixes many -Wduplicate-decl-specifier warnings due to the combination of
> const typeof() of already const variables.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> ---
> drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
> index a2d5244ff2b7..7f188f66931e 100644
> --- a/drivers/gpu/drm/nouveau/include/nvif/object.h
> +++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
> @@ -78,7 +78,7 @@ struct nvif_mclass {
> #define nvif_mclass(o,m) ({ \
> struct nvif_object *object = (o); \
> struct nvif_sclass *sclass; \
> - const typeof(m[0]) *mclass = (m); \
> + typeof(m[0]) *mclass = (m); \

Sorry, this messes up the spaces at the end, will send a v2.

> int ret = -ENODEV; \
> int cnt, i, j; \
> \
> --
> 2.18.0.rc1.244.gcf134e6275-goog
>

--
Thanks,
~Nick Desaulniers