Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare

From: Shawn Guo
Date: Sun Jun 17 2018 - 03:06:40 EST


On Tue, Jun 12, 2018 at 04:33:05PM +0200, Rafael J. Wysocki wrote:
> On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote:
> > This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924
> > Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg";
> > protected-headers="v1"
> > From: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > To: Shawn Guo <shawnguo@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>,
> > "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
> > Cc: kernel@xxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx,
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx,
> > linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>,
> > Liam Girdwood <lgirdwood@xxxxxxxxx>,
> > Leonard Crestez <leonard.crestez@xxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>,
> > Mark Rutland <mark.rutland@xxxxxxx>,
> > Michael Turquette <mturquette@xxxxxxxxxxxx>,
> > Stephen Boyd <sboyd@xxxxxxxxxxxxxx>, Fabio Estevam <fabio.estevam@xxxxxxx>,
> > Russell King <linux@xxxxxxxxxxxxxxx>
> > Message-ID: <daba73df-037c-2583-3a08-f3f27c4129d1@xxxxxxxxxxxxxx>
> > Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
> > References: <20180517055014.6607-1-o.rempel@xxxxxxxxxxxxxx>
> > <20180517055014.6607-4-o.rempel@xxxxxxxxxxxxxx>
> > In-Reply-To: <20180517055014.6607-4-o.rempel@xxxxxxxxxxxxxx>
> >
> > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg
> > Content-Type: text/plain; charset=utf-8
> > Content-Language: en-US
> > Content-Transfer-Encoding: quoted-printable
> >
> > Hi Rafael,
> >
> > Last version of this patch was send at 17.05.2018. No other comment was
> > provided and this patch is a blocker for other patches in this serie.
> > Can you please give some feedback on it.
>
> I would have done that had I not missed the patch.
>
> Which probably wouldn't have happened had you CCed it to linux-pm.
>
> Anyway, I have no particular problems with exporting pm_power_off_prepare via
> EXPORT_SYMBOL_GPL().

Rafael,

Can we have your explicit Acked-by tag on this patch? Thanks.

Shawn