Re: [PATCH 2/2] EDAC: i7core: fix memleaks and use-after-free on probe and remove

From: Borislav Petkov
Date: Mon Jun 18 2018 - 07:32:16 EST


On Tue, Jun 12, 2018 at 02:43:35PM +0200, Johan Hovold wrote:
> Make sure to free and deregister the addrmatch and chancounts devices
> allocated during probe in all error paths. Also fix use-after-free in a
> probe error path and in the remove success path where the devices were
> being put before before deregistration.
>
> Fixes: 356f0a30860d ("i7core_edac: change the mem allocation scheme to make Documentation/kobject.txt happy")
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 3.6
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
> drivers/edac/i7core_edac.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)

Both applied, thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.