Re: [PATCH v3] bitfield: fix *_encode_bits()

From: Jakub Kicinski
Date: Mon Jun 18 2018 - 16:33:39 EST


On Mon, 18 Jun 2018 22:28:03 +0200, Johannes Berg wrote:
> > For me looks like for consistency we may add fake conversion macros
> > for this, such as
> >
> > #define cpu_to_le8(x) x
> > #define le8_to_cpu(x) x
> > ...
> > #undef le8_to_cpu
> > #undef cpu_to_le8
> >
> > And do in the same way like below
> >
> > __MAKE_OP(8)
>
> I disagree with this. I don't see why we should have le8_encode_bits()
> and be8_encode_bits() and friends, that makes no sense.

+1