Re: [RFC PATCH v2 2/6] mtd: rawnand: add manufacturer fixup for ONFI parameter page

From: Boris Brezillon
Date: Tue Jun 19 2018 - 02:01:28 EST


On Tue, 19 Jun 2018 17:31:21 +1200
Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:

> This is called after the ONFI parameter page checksum is verified
> and allows us to override the contents of the parameter page.
>
> Suggested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>

> ---
> Changes in v2:
> - New
>
> drivers/mtd/nand/raw/nand_base.c | 4 ++++
> include/linux/mtd/rawnand.h | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 0cd3e216b95c..65250308c82d 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -5172,6 +5172,10 @@ static int nand_flash_detect_onfi(struct nand_chip *chip)
> }
> }
>
> + if (chip->manufacturer.desc && chip->manufacturer.desc->ops &&
> + chip->manufacturer.desc->ops->fixup_onfi_param_page)
> + chip->manufacturer.desc->ops->fixup_onfi_param_page(chip, p);
> +
> /* Check version */
> val = le16_to_cpu(p->revision);
> if (val & (1 << 5))
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 3e8ec3b8a39c..6db42091ee5e 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -783,6 +783,7 @@ struct nand_manufacturer_ops {
> void (*detect)(struct nand_chip *chip);
> int (*init)(struct nand_chip *chip);
> void (*cleanup)(struct nand_chip *chip);
> + void (*fixup_onfi_param_page)(struct nand_chip *chip, struct nand_onfi_params *p);
> };
>
> /**