Re: [PATCH] objtool: Add machine_real_restart() to the noreturn list

From: Matthias Kaehlcke
Date: Tue Jun 19 2018 - 14:01:52 EST


On Tue, Jun 19, 2018 at 10:47:50AM -0500, Josh Poimboeuf wrote:
> machine_real_restart() is annotated as '__noreturn", so add it to the
> objtool noreturn list. This fixes the following warning with clang and
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y:
>
> arch/x86/kernel/reboot.o: warning: objtool: native_machine_emergency_restart() falls through to next function machine_power_off()
>
> Reported-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

Tested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>

Thanks!