Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

From: Paolo Bonzini
Date: Wed Jun 20 2018 - 04:33:11 EST


On 20/06/2018 01:45, Matthias Kaehlcke wrote:
>
> v4.16 with an x86 allyesconfig and a few drivers disabled since they
> don't build with clang (yet):
>
> 16 occurrences of -Wconstant-conversion, including the ones fixed by
> this patch. Certainly no need for an endless churn of patches, and
> given the limited number it also doesn't seem likely that new
> instances will be added on a regular base.

Thanks for providing numbers! The next question is: how many of these
16 occurrences are actual bugs? This is what measures the usefulness of
the warning.

Paolo