Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl

From: Lucas Stach
Date: Wed Jun 20 2018 - 04:41:04 EST


Hi Nick,

Am Dienstag, den 19.06.2018, 23:07 +0100 schrieb Nick Dyer:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
>
> > Signed-off-by: Nick Dyer <nick@xxxxxxxxxxxxx>
> ---
> Âarch/arm/boot/dts/imx51-zii-rdu1.dts | 4 ++--
> Â1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index df9eca94d812..4d12ba54ba15 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -770,8 +770,8 @@
> Â
> > Â pinctrl_ts: tsgrp {
> > Â fsl,pins = <
> > > - MX51_PAD_CSI1_D8__GPIO3_12 0x85
> > > - MX51_PAD_CSI1_D9__GPIO3_13 0x85
> > > + MX51_PAD_CSI1_D8__GPIO3_12 4
> + MX51_PAD_CSI1_D9__GPIO3_13 (1<<16)

Please don't move away from using hex notation for the padctrl
settings.

Thanks,
Lucas