Re: [PATCHv4 08/18] atomics/generic: define atomic64_fetch_add_unless()

From: Ingo Molnar
Date: Thu Jun 21 2018 - 08:26:41 EST



* Mark Rutland <mark.rutland@xxxxxxx> wrote:

> On Thu, Jun 21, 2018 at 01:13:11PM +0100, Mark Rutland wrote:
> > - if (v->counter != u) {
> > + val = v->counter;
> > + if (val != u)
> > v->counter += a;
> > - ret = true;
> > }
>
> Ugh, I thought I had fixed this up and removed the trailing brace.
>
> This will break some 32-bit arches as-is.
>
> Ingo, would you be hapyp to fix this up, or would you prefer that I fix
> and resend?

I fixed it up, no need to resend unless I find other problems in testing.

> Sorry about this.

No problem!

Thanks,

Ingo