Re: [PATCH v3 7/7] x86/ldt,ptrace: provide regset access to the LDT

From: Andy Lutomirski
Date: Fri Jun 22 2018 - 10:49:32 EST


On Thu, Jun 21, 2018 at 2:18 PM H. Peter Anvin, Intel
<h.peter.anvin@xxxxxxxxx> wrote:
>
> From: "H. Peter Anvin" <hpa@xxxxxxxxxxxxxxx>
>
> Provide ptrace/regset access to the LDT, if one exists. This
> interface provides both read and write access. The write code is
> unified with modify_ldt(); the read code doesn't have enough
> similarity so it has been kept made separate.

For this and for the GDT, you've chosen to use struct user_desc as
your format instead of using a native hardware descriptor format. Any
particular reason why? If nothing else, it will bloat core files a
bit more than needed.