[PATCH] powerpc/xmon: avoid warnings about variables that might be clobbered by âlongjmpâ

From: Mathieu Malaterre
Date: Fri Jun 22 2018 - 15:27:37 EST


Move initialization of variables after data definitions. This silence
warnings treated as error with W=1:

arch/powerpc/xmon/xmon.c:3389:14: error: variable ânameâ might be clobbered by âlongjmpâ or âvforkâ [-Werror=clobbered]
arch/powerpc/xmon/xmon.c:3100:22: error: variable âtskâ might be clobbered by âlongjmpâ or âvforkâ [-Werror=clobbered]

Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
---
arch/powerpc/xmon/xmon.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 47166ad2a669..982848c784ff 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -3097,10 +3097,11 @@ static void show_pte(unsigned long addr)
static void show_tasks(void)
{
unsigned long tskv;
- struct task_struct *tsk = NULL;
+ struct task_struct *tsk;

printf(" task_struct ->thread.ksp PID PPID S P CMD\n");

+ tsk = NULL;
if (scanhex(&tskv))
tsk = (struct task_struct *)tskv;

@@ -3386,10 +3387,11 @@ static void xmon_print_symbol(unsigned long address, const char *mid,
const char *after)
{
char *modname;
- const char *name = NULL;
+ const char *name;
unsigned long offset, size;

printf(REG, address);
+ name = NULL;
if (setjmp(bus_error_jmp) == 0) {
catch_memory_errors = 1;
sync();
--
2.11.0