Re: [v3 PATCH] mm: thp: register mm for khugepaged when merging vma for shmem

From: Kirill A. Shutemov
Date: Fri Jun 22 2018 - 18:10:46 EST


On Sat, Jun 23, 2018 at 04:03:11AM +0800, Yang Shi wrote:
> When merging anonymous page vma, if the size of vma can fit in at least
> one hugepage, the mm will be registered for khugepaged for collapsing
> THP in the future.
>
> But, it skips shmem vma. Doing so for shmem too, but not file-private
> mapping, when merging vma in order to increase the odd to collapse
> hugepage by khugepaged.
>
> hugepage_vma_check() sounds like a good fit to do the check. And, moved
> the definition of it before khugepaged_enter_vma_merge() to suppress
> build error.
>
> Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx>
> Cc: Hugh Dickins <hughd@xxxxxxxxxx>
> Cc: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

--
Kirill A. Shutemov