Re: [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid

From: Chen-Yu Tsai
Date: Mon Jun 25 2018 - 23:17:59 EST


On Tue, Jun 26, 2018 at 1:09 AM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxx> wrote:
> On Sat, Jun 23, 2018 at 12:06:31AM +0800, Icenowy Zheng wrote:
>> Currently all ARM kernels will have s2idle enabled if CONFIG_SUSPEND is
>> present. In this case if the lid is closed, systemd-logind will enter
>> s2idle mode by default; however there's no possible wakeup source
>> defined, so the system will enter a forever idle.
>>
>> Add the lid itself as a wakeup source, thus the system can wakeup when
>> the lid is opened.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
>
> Applied both, thanks!
> Maxime

Icenowy, could you also look into having the power button as a wakeup source?
It has no device node, so you might have to look at how to implement it in
the driver.

ChenYu