Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.

From: Greg Kroah-Hartman
Date: Mon Jun 25 2018 - 23:56:51 EST


On Mon, Jun 25, 2018 at 08:50:26PM +0100, John Whitmore wrote:
> On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote:
> >
> > > On 25 June 2018 at 13:36 John Whitmore <arigead@xxxxxxxxx> wrote:
> > >
> > >
> > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote:
> > > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore <johnfwhitmore@xxxxxxxxx> wrote:
> > > > > Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
> > > > >
> > > >
> > > > Suggested-by ?
> > > >
> > >
> > > Em, not sure how to respond, it certainly wasn't my idea. I was just making
> > > coding style changes, badly. ;)
> >
> > Suggested-by is a tag for patches, to give credit. For example:
> >
> > https://elixir.bootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst
> >
> > See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:"
> >
> > Hope that helps,
> > Justin.
>
> Oops... that helps thank you. I have to re-read that document, it obvioiusly
> didn't all sink in :(

I've dropped this patch, can you fix it up and resend?

thanks,

greg k-h