Re: [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in rtw_macaddr_cfg()

[Michael Straube]

On 06/26/18 22:17, Joe Perches wrote:
> On Tue, 2018-06-26 at 21:44 +0200, Michael Straube wrote:
> > On 06/26/18 19:32, Andy Shevchenko wrote:
> > > On Tue, Jun 26, 2018 at 11:14 AM, Michael Straube
> > > <straube.linux@xxxxxxxxx> wrote:
> > > > Use ether_addr_copy() instead of memcpy() to copy the mac address.
> > >
> > > Suggested-by ?
> >
> > I'll add it. Sorry, I was not aware of the Suggested-by tag.
> >
> > > Btw, ensure that the source and destination buffers are aligned to u16
> > > as required by API.
> >
> > To be honest I'm not sure how to do that excactly.
> >
> > Use __align(2) in the array declarations? e.g.:
> >
> >           u8 mac[ETH_ALEN] __align(2);
>
> All initial function automatics are naturally aligned.
> >
So there is nothing to change? Now I'm confused.