Re: [PATCH] nvme: trace: add disk name to tracepoints

From: Sagi Grimberg
Date: Wed Jun 27 2018 - 04:06:35 EST



Not related to your patch, but I did notice that the req->q->id isn't
really useful here since that's not the hardware context identifier.
That's just some ida assigned software identifier. For the admin command
completion trace, it's actually a little confusing to see the qid in the
trace.

It was actually requested by Martin so we can easily see which request
got dispatched/completed on which request queue.

Would be good in the future to display the hwqid, but we'll need to work
before we can do that.

Maybe change the display to request_queue_id=%d?