Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

From: kbuild test robot
Date: Thu Jun 28 2018 - 11:36:35 EST


Hi Parthiban,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.18-rc2 next-20180628]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Parthiban-Nallathambi/iio-light-Add-support-for-vishay-vcnl4035/20180628-213034
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/iio/light/vcnl4035.c:136:28: sparse: cast to restricted __le16

vim +136 drivers/iio/light/vcnl4035.c

115
116 static irqreturn_t vcnl4035_trigger_consumer_handler(int irq, void *p)
117 {
118 struct iio_poll_func *pf = p;
119 struct iio_dev *indio_dev = pf->indio_dev;
120 struct vcnl4035_data *data = iio_priv(indio_dev);
121 int als_data;
122 int ret;
123
124 if (iio_trigger_using_own(indio_dev) && data->irq_timestamp) {
125 pf->timestamp = data->irq_timestamp;
126 data->irq_timestamp = 0;
127 }
128
129 if (!pf->timestamp)
130 pf->timestamp = iio_get_time_ns(indio_dev);
131
132 mutex_lock(&data->lock);
133 ret = regmap_read(data->regmap, VCNL4035_ALS_DATA, &als_data);
134 mutex_unlock(&data->lock);
135 if (!ret) {
> 136 als_data = le16_to_cpu(als_data);
137 iio_push_to_buffers_with_timestamp(indio_dev,
138 &als_data,
139 pf->timestamp);
140 } else
141 dev_err(&data->client->dev,
142 "Trigger consumer can't read from sensor.\n");
143 pf->timestamp = 0;
144
145 iio_trigger_notify_done(indio_dev->trig);
146
147 return IRQ_HANDLED;
148 }
149

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation