Re: [PATCH] leds: ledtrig-morse: send out morse code

From: Pavel Machek
Date: Fri Jun 29 2018 - 05:23:34 EST


On Fri 2018-06-29 04:24:39, Greg KH wrote:
> On Fri, Jun 29, 2018 at 10:07:17AM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > > There's no reason 2. should be in kernel ("mechanism, not policy").
> > > >
> > > > Given 1. is not really more complicated than the morse
> > > > trigger... please just help with pattern trigger if you want this to
> > > > happen.
> > >
> > > Ah, you want to do the conversion to morse code in userspace?
> > > Yes, that makes sense.
> >
> > Yes, that's what I want.
>
> We all want a pony :)

I already have a pony :-).

> Seriously, this is a very simple module, works well, and makes some
> system's life much easier as there is no external dependancy on a
> text-to-morse-code library needed.

It still does not belong into kernel.

It is interesting. You deleted bluetooth driver people used from
staging because of "not enough cleanups" and you want me to maintain
text-to-morse-code in the kernel?!

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature