Re: [PATCH v2] doc: dev-tools: kselftest.rst: update contributing new tests

From: Shuah Khan
Date: Fri Jun 29 2018 - 09:29:41 EST


On 06/29/2018 06:52 AM, Anders Roxell wrote:
> Add a description that kernel config options should be added into a
> config file that is placed next to the newly added test.
>
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> ---
> Documentation/dev-tools/kselftest.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index 3bf371a938d0..6f653acea248 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -156,6 +156,11 @@ Contributing new tests (details)
> installed by the distro on the system should be the primary focus to be able
> to find regressions.
>
> + * If a test needs specific kernel config options enabled, add a config file in
> + the test directory to enable them.
> +
> + e.g: tools/testing/selftests/android/ion/config
> +
> Test Harness
> ============
>
>
Thanks. Looks good to me.

Reviewed-by: Shuah Khan (Samsung OSG) <shuah@xxxxxxxxxx>


thanks,
-- Shuah