Re: [PATCH v2] crypto: skcipher: remove the exporting of skcipher_walk_next
From: Herbert Xu
Date: Sun Jul 01 2018 - 09:19:22 EST
On Tue, Jun 19, 2018 at 11:23:57PM +0300, efremov@xxxxxxxxx wrote:
> The function skcipher_walk_next declared as static and marked as
> EXPORT_SYMBOL_GPL. It's a bit confusing for internal function to be
> exported. The area of visibility for such function is its .c file
> and all other modules. Other *.c files of the same module can't use it,
> despite all other modules can. Relying on the fact that this is the
> internal function and it's not a crucial part of the API, the patch
> just removes the EXPORT_SYMBOL_GPL marking of skcipher_walk_next.
> Found by Linux Driver Verification project (linuxtesting.org).
> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
Patch applied. Thanks.
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt