Re: [PATCH 3/3] IIO: st_accel.h: sync DT and I2C device ID table strings

From: Nikolaus Voss
Date: Mon Jul 02 2018 - 03:32:58 EST

On Sat, 30 Jun 2018, Jonathan Cameron wrote:

On Fri, 29 Jun 2018 10:45:54 +0200
Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx> wrote:

I2C device ID table strings should really match the DT compatible
strings (without the manufacturer prefix) to avoid confusion. This is
especially reasonable when using ACPI PRP0001 HID /DT compatibility
entries along with the DT compatible property in DSD which is
used as a modalias (with manufacturer prefix stripped off) by the ACPI
layer and thus as i2c_board_info->type by the I2C layer.

Signed-off-by: Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>

Nice to have I agree. However, it's an ABI change as this is exposed
/sys/bus/iio/devices/iio:\deviceN/name and is used by lots of scripts
etc to identify the device. So we are stuck with it.

There is a reason we've kept this mess here for quite some time.

Ok, I feared there could be some reason ;-). Tell me, if you want me to respin anything...